Skip to content

Refactor: presentation#719

Merged
abdelrhman1002 merged 11 commits intodevelopfrom
refactor/presentation
Aug 21, 2025
Merged

Refactor: presentation#719
abdelrhman1002 merged 11 commits intodevelopfrom
refactor/presentation

Conversation

@abdelrhman1002
Copy link
Contributor

What does this PR do?

Type of Change

  • 🔧 Refactoring

Testing

  • Tested locally
  • Unit tests added/updated
  • UI tests added/updated

Checklist

  • Code builds without warnings
  • Self-reviewed
  • Tests pass
  • Ready for review

@abdelrhman1002 abdelrhman1002 requested a review from a team August 20, 2025 20:22
@abdelrhman1002 abdelrhman1002 self-assigned this Aug 20, 2025
@london-bot
Copy link
Contributor

london-bot bot commented Aug 20, 2025

[London Bot] Metrics Update Status

📊 PR metrics successfully updated for event: closed.

@london-bot
Copy link
Contributor

london-bot bot commented Aug 20, 2025

[London Bot] Auto-update Status

✅ Branch successfully updated from develop.

@github-actions
Copy link

github-actions bot commented Aug 21, 2025

Code Coverage Summary

File Coverage [53.47%]
presentation/src/main/java/com/london/presentation/feature/account/AccountViewModel.kt 83.78%
presentation/src/main/java/com/london/presentation/feature/account/rating/MyRatingViewModel.kt 97.37%
presentation/src/main/java/com/london/presentation/feature/authentication/register/RegistrationViewModel.kt 96.55%
presentation/src/main/java/com/london/presentation/feature/category/main/CategoriesViewModel.kt 100.00%
presentation/src/main/java/com/london/presentation/feature/category/tvshow/TvShowCategoryViewModel.kt 84.62%
presentation/src/main/java/com/london/presentation/feature/details/actor/ActorDetailsViewModel.kt 75.44%
presentation/src/main/java/com/london/presentation/feature/details/actor/info/gallery/ActorsGalleryViewModel.kt 81.25%
presentation/src/main/java/com/london/presentation/feature/details/actor/info/topmoviespicks/TopMoviesPicksViewModel.kt 56.00%
presentation/src/main/java/com/london/presentation/feature/details/actor/info/toptvshowspicks/TopTvShowsPicksViewModel.kt 83.33%
presentation/src/main/java/com/london/presentation/feature/details/movie/MovieDetailsViewModel.kt 77.31%
presentation/src/main/java/com/london/presentation/feature/details/tvshow/episode/EpisodeDetailsViewModel.kt 0.00%
presentation/src/main/java/com/london/presentation/feature/details/tvshow/info/TvShowDetailsViewModel.kt 40.31%
presentation/src/main/java/com/london/presentation/feature/home/HomeViewModel.kt 75.00%
presentation/src/main/java/com/london/presentation/feature/home/continuewatching/ContinueWatchingViewModel.kt 78.72%
presentation/src/main/java/com/london/presentation/feature/reviews/ReviewsViewModel.kt 77.42%
presentation/src/main/java/com/london/presentation/feature/search/SearchViewModel.kt 0.00%
presentation/src/main/java/com/london/presentation/feature/welcome/onboarding/OnboardingViewModel.kt 95.65%
presentation/src/main/java/com/london/presentation/feature/welcome/splash/SplashViewModel.kt 0.00%
Total Project Coverage 60.78%

Copy link
Contributor

@BassantM BassantM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You moved the section package to shared package, but it is the wrong behavior; it was not shared

@abdelrhman1002 abdelrhman1002 enabled auto-merge (squash) August 21, 2025 16:06
@abdelrhman1002
Copy link
Contributor Author

You moved the section package to shared package, but it is the wrong behavior; it was not shared

You moved the section package to shared package, but it is the wrong behavior; it was not shared

check now

Copy link
Collaborator

@yusufnasserdev yusufnasserdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, smaller PRs in the future will be lovely!

@abdelrhman1002 abdelrhman1002 merged commit 032b74f into develop Aug 21, 2025
12 checks passed
@abdelrhman1002 abdelrhman1002 deleted the refactor/presentation branch August 21, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants