Skip to content

Feature: APK Naming#724

Merged
yusufnasserdev merged 13 commits intodevelopfrom
feature/apk-name
Aug 26, 2025
Merged

Feature: APK Naming#724
yusufnasserdev merged 13 commits intodevelopfrom
feature/apk-name

Conversation

@yusufnasserdev
Copy link
Collaborator

Feature: Modernize Build Config, Standardize APK Naming, and Clean Up Project

Overview

This pull request is a comprehensive update to modernize the project's build configuration, target the latest Android SDK, and simplify the overall structure. By centralizing version management and cleaning up redundant files, this PR improves maintainability and prepares the project for future development.


Key Changes

  • 🎯 Target SDK Update

    • The project's compileSdk and targetSdk have been updated to 36.
    • SDK versions are now centrally managed in buildSrc/AppConfig.kt for consistency across all modules.
  • 🛠️ Build Configuration Refactor

    • The app and ImageHaramBlur modules now inherit their SDK versions from AppConfig, eliminating hardcoded values.
    • ABI splits are now configured in the app module to generate a universal APK and exclude older, unused architectures.
  • 📦 CI/CD Pipeline Standardization

    • The output APK filename is now standardized to the format Novix-{versionName}-{abi}-release.apk by setting archivesName in build.gradle.kts.
    • The cd.yml GitHub Actions workflow has been updated to use this new, predictable naming convention for Firebase uploads.
  • 🧹 Project & Resource Cleanup

    • Removed unnecessary AndroidManifest.xml files from the data, designSystem, and presentation library modules.
    • Consolidated the INTERNET permission into the main app manifest.
    • Deleted several unused drawable resources, the redundant app/src/main/res/values/strings.xml file, and simplified the app theme in themes.xml.

@yusufnasserdev yusufnasserdev requested review from a team August 25, 2025 09:19
@yusufnasserdev yusufnasserdev self-assigned this Aug 25, 2025
@london-bot
Copy link
Contributor

london-bot bot commented Aug 25, 2025

[London Bot] Metrics Update Status

📊 PR metrics successfully updated for event: closed.

@london-bot
Copy link
Contributor

london-bot bot commented Aug 25, 2025

[London Bot] Auto-update Status

✅ Branch successfully updated from develop.

@yusufnasserdev yusufnasserdev marked this pull request as ready for review August 25, 2025 09:23
@github-actions
Copy link

Code Coverage Summary

Total Project Coverage 60.68%

@yusufnasserdev yusufnasserdev merged commit ef867d0 into develop Aug 26, 2025
12 checks passed
@yusufnasserdev yusufnasserdev deleted the feature/apk-name branch August 26, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants