fix: Remove zero star rating #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed unnecessary post update in MapView - Updated onRatingChanged passed to PostItem mappings in Feed and MapView to ensure correctness of rating averages
Closed
…ter update - Updated the selected post of the viewmodel to ensure the mapview's selectedPost value is set to the updated post. This allows MapView to maintain continuous updates of the parameters in the image preview dialog. - Removed unnecessary launched effect
… view - Updated PostItem to display ratings only if wanted - Refactored GoogleMap and MapView so that ratings don't display when selecting a post - Made ImagePreviewDialog deny the display of ratings
- Replaced testStarIsDisplayed with testStarIsNotDisplay - Commented out testStarClickClassUdpatePost as it isn't meaningful anymore
…and FeedScreen - Moved rating logic and concurrency-safe updates (Firestore transactions) into PostsViewModel. - Removed direct rating calculations from FeedScreen, relying instead on ViewModel’s state and methods. - Initialize and observe post ratings and user profiles in the ViewModel to ensure a single source of truth. - Improved performance and stability by avoiding repeated rating initializations and ensuring atomic updates. - Enhanced code maintainability and reduced UI complexity by centralizing business logic in the ViewModel.
|
rihabbelmekki
approved these changes
Dec 20, 2024
Contributor
rihabbelmekki
left a comment
rihabbelmekki
left a comment
There was a problem hiding this comment.
Great code! The changes correctly fix the rating state inconsistency issues by:
Removing the separate state management functions and bringing the logic back inline
Improving the profile state handling to ensure ratings are properly reinitialized when navigating back to the feed
Adding proper profile loading checks before initializing ratings
The code is now more robust and maintains consistent state across navigation. Tested and confirmed that ratings persist correctly when navigating between screens. Good to merge!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request solves issue #209
Note: Drafted due to a bug that may necessitate significant changes in the Google Maps implementation.