Skip to content

Conversation

@rihabbelmekki
Copy link
Contributor

@rihabbelmekki rihabbelmekki commented Dec 19, 2024

Changes

This PR enhances the overall app's UI, particularly the Profile Information screen's UI and improves the user experience around profile deletion.

UI Improvements

  • Changed background image in multiple screens
  • Added darker backgrounds to text fields for better visibility
  • Ensured text remains white in all input states (focused/unfocused)
  • Updated button colors to match app theme

UX Enhancements

  • Added confirmation dialog for profile deletion to prevent accidental deletions
  • Dialog provides clear "Yes" and "Cancel" options with consistent styling

Testing

  • Added new test cases for confirmation dialog interactions
  • Updated existing tests to cover dialog flows
  • Maintained test coverage for all UI components

Related Issues:
Closes #259

- Changed background for multiple screens
- Update theme color for consistency across buttons
- Implement confirmation dialog for profile deletion
- Add tests for delete confirmation dialog
@rihabbelmekki rihabbelmekki self-assigned this Dec 19, 2024
@rihabbelmekki rihabbelmekki changed the title enhance overall UI Enhance overall UI Dec 19, 2024
@rihabbelmekki rihabbelmekki linked an issue Dec 19, 2024 that may be closed by this pull request
Copy link
Contributor

@Ismaillat Ismaillat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great UI changes! The app now feels more visually appealing, and the updated buttons look more aesthetic. The new background perfectly complements the app's theme. However, the buttons on the quizz screen have not been updated. Addressing this issue would further enhance the overall UI.

Copy link
Contributor

@Ismaillat Ismaillat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UI changes look great to me. Approved for merge.

…ll-ui

# Conflicts:
#	app/src/androidTest/java/com/github/lookupgroup27/lookup/ui/authentication/SignInKtTest.kt
#	app/src/main/java/com/github/lookupgroup27/lookup/ui/overview/Menu.kt
#	app/src/main/java/com/github/lookupgroup27/lookup/ui/profile/Profile.kt
#	app/src/main/java/com/github/lookupgroup27/lookup/ui/profile/ProfileInformation.kt
#	app/src/main/java/com/github/lookupgroup27/lookup/ui/quiz/Quiz.kt
@sonarqubecloud
Copy link

@rihabbelmekki rihabbelmekki merged commit 992d8b0 into main Dec 20, 2024
3 checks passed
@rihabbelmekki rihabbelmekki deleted the feature/enhance-overall-ui branch December 20, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhance Overall UI

3 participants