Skip to content

Conversation

@marionbarker
Copy link
Collaborator

Purpose

Several improvements to the UI for pods were implemented in a private repository (OmnipodKit) being prepared to replace both OmniBLE and OmniKit with a single repository.

This PR brings over improvements implemented there first.

The graphic below shows the Omnipod DASH screen before (to the left) and after (to the right) applying this PR.

ImprovementsFromOmnipodKit
  • The new row, red rectangle: Delivery Ends makes it easy to know when a particular pod will stop delivering insulin
  • The new wording on an existing row, blue rectangle, uses "Expiration"
    • This removes the need to modify the row from "Expires" to "Expired" when pod expires

Method

The two PR that are the source for this PR are, for those who have access,

The detailed comments in those PR are:

PR 11:
Rework so that tapping the sound icon while a bolus is in progress won't leave the icon disabled
PR 14:
* Updated basalDeliveryState improves inactive pod situations
* Set previousPodState activeTime for simulator pod deactivation
* Add pairAndPrime() mockStartDate for easier simulator testing
* PodDetails uses DetailedStatus instead of FaultEventCode and pdmRef
* Update Pod Details view to include Pod Activated row
* Pump view has Pod Activated, Pod Expiration and Delivery Stops times
* Delivery Stops time changees to Pod Faulted time on pod fault
* Simplifed and fixed localizable strings and comments for pump views
* Minor source code formatting fixes
* Removed unused refreshTimer variable in OmniHUDProvider

@marionbarker marionbarker requested a review from itsmojo November 29, 2025 03:26
@marionbarker marionbarker marked this pull request as draft November 30, 2025 14:27
@marionbarker
Copy link
Collaborator Author

Convert this to a draft:

  1. Some issues with UI best-practices were pointed out
  2. The developer of OmnipodKit uses the presence/absence of the Delivery row as an aid to remembering if the test phone used the new program manager to add the current pod (typicallly an rPi DASH simulated pod)

Spacer()
Text(self.viewModel.faultedAtString)
.foregroundColor(Color.secondary)
} else if viewModel.podOk {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete the "if viewModel.podOk " portion of this line to prevent a blank row display for this row when there is no pod to match the behavior with no pod of all the other rows in this section

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants