Remove automatically appending jj-spr version#44
Open
dannysu wants to merge 1 commit intoLucioFranco:mainfrom
Open
Remove automatically appending jj-spr version#44dannysu wants to merge 1 commit intoLucioFranco:mainfrom
dannysu wants to merge 1 commit intoLucioFranco:mainfrom
Conversation
Ideally, the user has full control of what shows up. Having an automatic appending message is pretty annoying.
LucioFranco
reviewed
Oct 29, 2025
| local_commit.parent_oid, | ||
| &format!( | ||
| "[spr] {}\n\nCreated using jj-spr {}\n\n[skip ci]", | ||
| "[spr] {}\n\n[skip ci]", |
Owner
There was a problem hiding this comment.
I feel like it would be nice if we could store this somewhere in the git metadata at least?
There was a problem hiding this comment.
Hi Lucio. Can you please explain why you want it? I am curious.
Owner
There was a problem hiding this comment.
To be able to track down what version of the tool potentially created some sort of bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ideally, the user has full control of what shows up. Having an automatic appending message is pretty annoying IMO.