This pull request fix one bug and close 2 issues.#6
Open
liuruoze wants to merge 2 commits intoLucretiel:masterfrom
Open
This pull request fix one bug and close 2 issues.#6liuruoze wants to merge 2 commits intoLucretiel:masterfrom
liuruoze wants to merge 2 commits intoLucretiel:masterfrom
Conversation
Owner
|
Thanks for the PR! I'll review it this weekend and merge it if it all looks good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this pr will fix one bug in discrete.py, make the example work correctly, and close 2 issues which are #4 and #5 . I have test this code in python 3 and it should work well. All you need is to click the 'automatic merge' button :) .
@Lucretiel , if you have some question about this pr, please contact me :) .