Fix makefile to not use explicit hls4ml/hls paths #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
missirol
reviewed
Jan 6, 2026
missirol
left a comment
missirol
left a comment
There was a problem hiding this comment.
There are still two references to /cvmfs in test_model/Makefile. Could they be removed in this PR ?
I also left two minor comments inline.
Removed INCLUDES variable from Makefile
Author
|
I did the extra clean up as Marino suggested, though for the test_model I actually don't know if it should not be completely removed from this repo - I'd prefer it to be removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing this comment cms-hls4ml#2 (review)