Fix authentication crash due to URL fragment (#) parsing and improve error handling#6
Open
Spet001 wants to merge 1 commit intoLukeFZ:masterfrom
Open
Fix authentication crash due to URL fragment (#) parsing and improve error handling#6Spet001 wants to merge 1 commit intoLukeFZ:masterfrom
Spet001 wants to merge 1 commit intoLukeFZ:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash that occurs during the authentication process when the user pastes the callback URL.
The Issue: The current authentication flow often results in a callback URL containing a fragment identifier (#) instead of query parameters (? or &). This format was causing a System.IO.InvalidDataException: Invalid URL fragment when processed by the AuthenticationService, leading to an immediate application crash.
The Fix:
URL Sanitization: Added logic to automatically detect and correct the URL format. If the input contains an access_token but has lost its fragment (or has it malformed), the code now attempts to restore the # to ensure compatibility with XboxWebApi.
Error Handling: Wrapped the authentication logic in a try-catch block. Instead of crashing the entire application upon a parsing error, it now catches the exception and displays the full error message and stack trace to the user, allowing for easier debugging.
Validated that this resolves the "Invalid URL fragment" crash and successfuly authenticates.