Defer pathc loading and buffer pathc reads#3
Open
IvanKarpan wants to merge 1 commit intoLukeFZ:masterfrom
Open
Defer pathc loading and buffer pathc reads#3IvanKarpan wants to merge 1 commit intoLukeFZ:masterfrom
IvanKarpan wants to merge 1 commit intoLukeFZ:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While extracting a few loose game files from a Windows drive through WSL (
/mnt/d/...), anything that spun upPackageContextfelt like it hung right after starting work—the process barely moved for ages even for paths that aren't partial DDS.That turned out to be because we always parsed
meta/0.pathcduringPackageContextconstruction, and did it with lots of tiny reads. This defers loading PATHC until a partial DDS actually needs it, and reads the whole0.pathcfile into memory before parsing so we aren't streaming small reads off disk.