Skip to content

Ghc9 support#1

Open
LupusAnay wants to merge 3 commits intomasterfrom
ghc9-support
Open

Ghc9 support#1
LupusAnay wants to merge 3 commits intomasterfrom
ghc9-support

Conversation

@LupusAnay
Copy link
Copy Markdown
Owner

No description provided.

@pr-explainer-bot
Copy link
Copy Markdown

Hello there! I see you need a Pull Request report. Let's get started!

Changes

  1. Migrated to GHC 9.0.2
  2. Updated Travis CI configuration to include new GHC versions
  3. Added support for aeson-1

Suggestions

Sorry, I can't provide suggestions without specific lines of code to refer to.

Bugs

  1. In src/Control/Monad/Twilio.hs, the TwilioException type's Eq instance has been removed, potentially causing issues with equality checks.
  2. In src/Twilio/Types/Capability.hs, the KeyMap import is not properly conditionalized for aeson versions below 2.0.0, which could cause build failures.

Improvements

  1. In src/Twilio/Types/List.hs, the Key type should be properly conditionalized for aeson versions below 2.0.0 to avoid build failures.
  2. In src/Twilio/Types/List.hs, the parseJSONToList function could benefit from better error handling and reporting.

Here's an example of how parseJSONToList could be refactored for better readability:

parseJSONToList :: Value -> Parser a
parseJSONToList o@(Object v) = do
  let plural = getConst (getPlural :: Const Key (a, b))
  maybePagingInformation <- case fromJSON o of
    Success pagingInformation -> return $ Just pagingInformation
    _                         -> return Nothing
 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant