Skip to content

Conversation

@nagmat84
Copy link
Collaborator

@nagmat84 nagmat84 commented Apr 7, 2022

Partially fixes LycheeOrg/Lychee#1251

As MySQL does not comly to ANSI SQL and does not support statement consistency, but only simple row consistency, the order of rows is important when a complete sub-tree is deleted.

@nagmat84
Copy link
Collaborator Author

nagmat84 commented Apr 7, 2022

Maybe someone of you (@kamil4, @ildyria) understands why 1 out of 9 tests is failing. If I understand the output of the failing test correctly, it is not the code itself which fails, but the PHP lexer when PHPunit tries to calculate the test coverage.

@ildyria
Copy link
Member

ildyria commented Apr 10, 2022

LGTM, see: #7

@nagmat84 nagmat84 merged commit 973684d into v5 Apr 10, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix_order_of_deletion branch April 10, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing thumbs on map, cover on albums and Show nothing in some albums (other albums are normal)

3 participants