Skip to content

subclassing ndarray #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

subclassing ndarray #12

wants to merge 11 commits into from

Conversation

@sy3394
Copy link
Collaborator

@sy3394 sy3394 commented Mar 7, 2023

No description provided.

sbacchio
sbacchio reviewed Mar 8, 2023
View reviewed changes
sbacchio
sbacchio requested changes Mar 8, 2023
View reviewed changes
Copy link
Member

@sbacchio sbacchio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, I really like this cleaning! Maybe just change the name of the PR as well.. e.g. "Subclassing ndarray" would do it.
EDIT: there is also an easy conflict to fix

sbacchio
sbacchio reviewed Mar 8, 2023
View reviewed changes
@sy3394 sy3394 changed the title Sycl subclassing ndarray Mar 8, 2023
sbacchio
sbacchio approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@sbacchio sbacchio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now! So there are just few things to do from my side before merging:

  • improve allclose in lyncs_utils
  • investigate seg. fault with evenodd
  • check other packages still work with this version

@sbacchio sbacchio mentioned this pull request Mar 8, 2023
Open
6 tasks
@sbacchio sbacchio linked an issue Mar 29, 2023 that may be closed by this pull request
Some cleaning tasks #10
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbacchio sbacchio sbacchio approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Some cleaning tasks

3 participants

@sy3394 @sbacchio