viking: Check calls to unimplemented functions#2
Open
MonsterDruide1 wants to merge 1 commit intoLynxDev2:file-list-toolsfrom
Open
viking: Check calls to unimplemented functions#2MonsterDruide1 wants to merge 1 commit intoLynxDev2:file-list-toolsfrom
MonsterDruide1 wants to merge 1 commit intoLynxDev2:file-list-toolsfrom
Conversation
Author
|
As discussed in DMs, these changes should be applied on upstream instead: I'll leave this PR open to serve as reference when porting the changes back into our fork. Close it whenever you like @LynxDev2 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Well, yea, what it says in the title.
InternalError, to be used when something unexpected happens within viking. Should hopefully never be shown to the user, but I would rather display a cryptic mismatch (that can be ignored by marking as "mismatching") rather than silently fail and mark it as matching (existing behaviour, probably still happens for some things).dynsymand.dynstrtabto resolve names of.plt-references.pltto list of functions, to allow them to be "resolved" when comparing. For example, if some code callscos(...),cosis not listed in thefile_list.yml, so should rather be imported from.plt.The logic in 4 was mostly in place before as well, but has now been extended with multiple
plt_X_to_Xcalls, which take over when the "standard functions" return no results: Functions in the PLT have a symbol, but it's pointing to0instead of the actual function, so name/address have to be mapped via relocations.