not throwing error when optional input with no default#221
Open
grallewellyn wants to merge 1 commit intodevelopfrom
Open
not throwing error when optional input with no default#221grallewellyn wants to merge 1 commit intodevelopfrom
grallewellyn wants to merge 1 commit intodevelopfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Only raise an error when no default and not optional. If optional and no default, don't pass anything
Also, show optional when listing information about params
I didn't get a reply to this on slack:
But I think we should keep as is and @marjo-luc should not pass the argument to the API if the user leaves it blank
If the user is technical and submitting their job from maap-py or the API, they should have the option to override the optional with a default problem by passing an empty string for the argument they actually want to leave empty
Also, we should keep the existing functionality that users have come to know