Skip to content

feat: add email forwarder infrastructure#1

Merged
jjfrench merged 5 commits intomainfrom
feat/email-forwarding
Mar 3, 2026
Merged

feat: add email forwarder infrastructure#1
jjfrench merged 5 commits intomainfrom
feat/email-forwarding

Conversation

@jjfrench
Copy link
Copy Markdown
Member

Description

Project setup using uv

  • uv sync
  • uv run pytest -q
  • uv run cdk synth

@jjfrench jjfrench requested a review from hrodmn February 24, 2026 21:33
Copy link
Copy Markdown

@hrodmn hrodmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reviewing the logic in the Lambda function it would be helpful to have a little more context about what we are trying to accomplish!

As far as infrastructure goes I would prefer if we moved the config.json with email addresses to a pydantic-settings module that can read from env vars or a env.yml file. In eoapi-devseed I set up a GitHub actions environment variable that contains some settings in yml format in case you don't want to manage multiple variables.

@jjfrench
Copy link
Copy Markdown
Member Author

jjfrench commented Mar 2, 2026

@hrodmn

For reviewing the logic in the Lambda function it would be helpful to have a little more context about what we are trying to accomplish!

The previous lambda in the UAH account (us-east-1) was using a library to forward emails using a mapping of recipients to forward addresses. The lambda here tries to accomplish the same thing without the need for an additional library

@jjfrench jjfrench requested a review from hrodmn March 3, 2026 01:53
@jjfrench
Copy link
Copy Markdown
Member Author

jjfrench commented Mar 3, 2026

I agree, this way of config is cleaner. The previous structure was just a mirror of what was in UAH - I'll modify the repo permissions to include the JPL team so that they can add people to the environment variable.

As far as changes go, a couple of things,

  • added suggested config changes
  • moved config to top level, adjusted build
  • cleaned up testing structure

Copy link
Copy Markdown

@hrodmn hrodmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the configuration style! Right now the Lambda code is bundling a few files I don't think we need. As far as I can tell we just want to include the source files in the lambda/ directory (plus config.py) so I recommend restructuring the python files a bit so that is clear.

@jjfrench jjfrench requested a review from hrodmn March 3, 2026 18:25
@jjfrench jjfrench merged commit 5ce44ca into main Mar 3, 2026
1 check passed
@jjfrench jjfrench deleted the feat/email-forwarding branch March 3, 2026 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants