Conversation
hrodmn
left a comment
There was a problem hiding this comment.
For reviewing the logic in the Lambda function it would be helpful to have a little more context about what we are trying to accomplish!
As far as infrastructure goes I would prefer if we moved the config.json with email addresses to a pydantic-settings module that can read from env vars or a env.yml file. In eoapi-devseed I set up a GitHub actions environment variable that contains some settings in yml format in case you don't want to manage multiple variables.
The previous lambda in the UAH account (us-east-1) was using a library to forward emails using a mapping of recipients to forward addresses. The lambda here tries to accomplish the same thing without the need for an additional library |
|
I agree, this way of config is cleaner. The previous structure was just a mirror of what was in UAH - I'll modify the repo permissions to include the JPL team so that they can add people to the environment variable. As far as changes go, a couple of things,
|
hrodmn
left a comment
There was a problem hiding this comment.
Thanks for updating the configuration style! Right now the Lambda code is bundling a few files I don't think we need. As far as I can tell we just want to include the source files in the lambda/ directory (plus config.py) so I recommend restructuring the python files a bit so that is clear.
Description
Project setup using
uv