Conversation
|
Maybe if object is invisible return his bounding box as null/empty point ? |
MAKMED1337
left a comment
MAKMED1337
left a comment
There was a problem hiding this comment.
Very strange idea with invisibility, that is ignored half of the time.
core/src/com/po/fuck/model/collections/CollidableCollection.java
Outdated
Show resolved
Hide resolved
|
|
||
| Polygon getCollision(); | ||
|
|
||
| boolean isInvisible(); |
There was a problem hiding this comment.
What does it mean ? Very strange logic, it does not even affect collide.
There was a problem hiding this comment.
It affects it. return objects.stream().filter(x -> !x.isInvisible() && x.collide(other)).collect(Collectors.toList());
There was a problem hiding this comment.
But what does invisible state mean ? If it still collides, and it only affects physics.
| // TODO: this is a temporary solution, we need to add a way to check if the enemies are dead | ||
| // without relying on collidable collection. |
There was a problem hiding this comment.
I don't think that enemies should leave the room.
Move `getZ` into drawers
…nstead-of-some-constants' into 15-use-properties-instead-of-some-constants
…ation-when-spawning-gameobject-intersecting-entity' into 23-avoid-stuck-situation-when-spawning-gameobject-intersecting-entity
MAKMED1337
left a comment
MAKMED1337
left a comment
There was a problem hiding this comment.
I still don't like the idea with invisibility that can be tested, why are we getting "internal" object state ?
core/src/com/po/fuck/model/collections/CollidableCollection.java
Outdated
Show resolved
Hide resolved
We are not getting an internal state. We are checking whether it is invisible. I consider it normal. |
Then what does invisible mean ? |
…veral fields private
…ome-constants Added .properties files
It means that object currently cannot collide with anyone. |
…ation-when-spawning-gameobject-intersecting-entity' into 23-avoid-stuck-situation-when-spawning-gameobject-intersecting-entity
So why is there a method |
2 participants
No description provided.