Skip to content

code review from zhangzhang li #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gloria20070108 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

code review from zhangzhang li #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions code_review_zhangzhang
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
UX Feedbacks:

1. Great Styles and the webpage is very easy to use!
2. The "Tada" Dialog is cute. However, it is a little distractive for user.
3. While filtering by a tag, there is no way to remove the filter except clicking the Home link. (this could be a future feature)
4. The search item input requires enter to take effect. It will be better if it can do search with the input.
5. the layout of Edit/Delete buttons in the "My Articles" may need some improve.
6. Maybe have a logo to replace the "Your Company Logo" in the login page.

Code feedback:

1. nice code organization!
2. remove unused files like App.css.
3. should have propTypes for all the components
4. in NewArticle.js, used then() in some async functions. async/await should be better
5. in myDB.js, "tagFilter === '' || tagFilter === undefined" could be simplied as "!tagFilter"