Require elections.delete for election delete operation#12
Merged
Technofied merged 4 commits intoMCCitiesNetwork:masterfrom Feb 11, 2026
Merged
Require elections.delete for election delete operation#12Technofied merged 4 commits intoMCCitiesNetwork:masterfrom
Technofied merged 4 commits intoMCCitiesNetwork:masterfrom
Conversation
To keep things consistent. Manager, as opposed to admin, is a pretty "low" permission to have. It should not have access to sensitive operations such as deletion by default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manager, as opposed to admin, is a pretty "low" permission to have. It is probably best to not let managers have access to very sensitive operations, such as deletion, by default. This PR restricts it behind the already existing
elections.deletepermission node.