Open
Conversation
Removed player name check that always fails to work on non host instances
Contributor
|
have you tested this in splitscreen? |
Contributor
Author
|
Yep works too. |
Contributor
Author
|
I tested (all with and without the fix):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a non host player enters the end fountain after killing the dragon the game crashes.
Changes
Previous Behavior
Game crashes when entering the end fountain as a "secondary" player
Root Cause
The game tries to use a check for the player name but fails and crashes the game.
New Behavior
Game does not crash.
Fix Implementation
Remove broken name check.
AI Use Disclosure
No AI was used.
Related Issues