Batch D3 and SevenNetD3Model for Torch-Sim interface#300
Draft
alphalm4 wants to merge 3 commits intoMDIL-SNU:mainfrom
Draft
Batch D3 and SevenNetD3Model for Torch-Sim interface#300alphalm4 wants to merge 3 commits intoMDIL-SNU:mainfrom
alphalm4 wants to merge 3 commits intoMDIL-SNU:mainfrom
Conversation
Contributor
Author
|
Something like this might force Torch-Sim to run in float64 while preserving SevenNet works in float32. |
Member
|
I dont know the context but why dont we just cast 7net model to float64? For speed? |
Contributor
Author
|
7net model을 64로 올리지않는건 speed 때문이 맞습니다. (굳..이?) 맥락을 추가하자면 해당 항목은 TorchSim state precision이 model precision을 따라가기 때문입니다. SevenNet은 float32 만 받기 때문에 현재 기준으로는 강제로 MD도 float32로 돌려야 합니다. 아주 정밀하게 확인한 건 아니지만, float64 wrapper 구현 후 ensemble invariant (e.g. npt_nose_hoover_invariant) fluctuation을 확인했을 때 float32보다 줄어드는 것으로 보입니다 (즉 계산 오차 감소가 눈에 보입니다). 반드시 그것뿐만이 아니라도, MD precision을 선택할 방법은 있어야 할 것 같습니다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch D3 is implemented
pair_d3_for_aseSevenNetD3Model in
torchsim_d3module directly use Batch D3.For reference, I also added SevenNetModel + D3Calculator (serial) version in
torchsimmodule. (will be replaced with above)For testing, high-precision patch in torch-sim might be required: TorchSim/torch-sim@a858fbd(resolved)sevenn inferencetorchsim_d3.pymaxijterm, I feel the issue is resolved but not checked yet)