tweaks to semiempirical buffet model#18
Open
Asthelen wants to merge 1 commit intoMDOBenchmarks:mainfrom
Open
Conversation
…rking with OpenMDAO)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that the buffet_openmdao complex step derivatives were being returned as zeros, so in buffet_openmdao I made all np.zero arrays complex which seemed to fix it.
In my case 4 model that integrates this component into the full system, I also had issues with the inputs being arrays vs. scalars, which I tried to resolve by turning inputs into scalars when needed. I also had trouble with the deg2rad function a while ago (don't recall what the error was but I'll try to look into it), so I just manually converted the units using a factor of pi/180.
Also: I noticed that the taper and aspect ratio derivatives are zero for some reason, which perhaps needs to be investigated.