Skip to content

Adds option to show proactive feedback automatically#182

Merged
MP-DG merged 5 commits intomainfrom
proactive-feedback
Dec 18, 2025
Merged

Adds option to show proactive feedback automatically#182
MP-DG merged 5 commits intomainfrom
proactive-feedback

Conversation

@MP-DG
Copy link
Contributor

@MP-DG MP-DG commented Dec 18, 2025

Description of changes

Currently polls for proactive feedback whenever a student is inside of a course.

How has this been tested?

Please describe the test strategy you followed.

  • automated unit test
  • automated integration test
  • automated acceptance test
  • manual, exploratory test

In case of manual test, please document the test well including a set of user instructions and prerequisites. Each including an action, it's result, and where appropriate a screenshot.

First Test

  1. Navigate inside of a course.
  2. Open network analysis

    -> You see request for proactive feedback periodically

Second Test

  1. Navigate inside of a course
  2. Trigger proactive feedback (see tutor_service for infos on how to)

    -> The tutor chat opens up automatically and displays proactive feedback

Checklist before requesting a review

  • My code follows the coding guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My code fulfilles all acceptance criteria
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation
  • I have added explanation of architectural decision and rationales to wiki/adr
  • I have updated the changes in the ticket description

Checklist for reviewer

  • The code works and does not throw errors
  • The code is easy to understand and there are no confusing parts
  • The code follows the coding guidelines of this project
  • The code change accomplishes what it is supposed to do
  • I cannot think of any use case in which the code does not behave as intended
  • The added and existing tests reasonably cover the code change
  • I cannot think of any test cases, input or edge cases that should be tested in addition
  • Description of the change is included in the documentation

@MP-DG MP-DG requested a review from nk-coding December 18, 2025 12:33
onCompleted: (response:any, errors:any) => {
const answer = response?.sendMessage?.answer;
if (answer) {
if (answer !== "No proactive feedback available at the moment.") {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that seems to be a hack
are there no status codes etc. for sth like this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, the tutor_service always returns this message whenever it gets checked if proactive feedback exists and there is no feedback to return. To prevent this message to flood the tutor chat, it gets filtered out this way

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stil a hack, but ok

@nk-coding nk-coding self-requested a review December 18, 2025 13:17
@MP-DG MP-DG merged commit 567143c into main Dec 18, 2025
3 of 5 checks passed
@MP-DG MP-DG deleted the proactive-feedback branch December 18, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants