Adds option to show proactive feedback automatically#182
Merged
Conversation
nk-coding
requested changes
Dec 18, 2025
| onCompleted: (response:any, errors:any) => { | ||
| const answer = response?.sendMessage?.answer; | ||
| if (answer) { | ||
| if (answer !== "No proactive feedback available at the moment.") { |
There was a problem hiding this comment.
that seems to be a hack
are there no status codes etc. for sth like this?
Contributor
Author
There was a problem hiding this comment.
Currently, the tutor_service always returns this message whenever it gets checked if proactive feedback exists and there is no feedback to return. To prevent this message to flood the tutor chat, it gets filtered out this way
nk-coding
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Currently polls for proactive feedback whenever a student is inside of a course.
How has this been tested?
Please describe the test strategy you followed.
In case of manual test, please document the test well including a set of user instructions and prerequisites. Each including an action, it's result, and where appropriate a screenshot.
First Test
-> You see request for proactive feedback periodically
Second Test
-> The tutor chat opens up automatically and displays proactive feedback
Checklist before requesting a review
Checklist for reviewer