Skip to content

adjust frontend to skillValue and skillAllUsersStats#185

Merged
sangaran10 merged 4 commits intomainfrom
progress-visualization
Jan 19, 2026
Merged

adjust frontend to skillValue and skillAllUsersStats#185
sangaran10 merged 4 commits intomainfrom
progress-visualization

Conversation

@sangaran10
Copy link
Contributor

@sangaran10 sangaran10 commented Jan 16, 2026

Description of changes

adjust frontend to simplification of skillValue and skillAllUsersStats in gateway

How has this been tested?

Please describe the test strategy you followed.

  • automated unit test
  • automated integration test
  • automated acceptance test
  • manual, exploratory test

In case of manual test, please document the test well including a set of user instructions and prerequisites. Each including an action, it's result, and where appropriate a screenshot.

Checklist before requesting a review

  • My code follows the coding guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My code fulfilles all acceptance criteria
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation
  • I have added explanation of architectural decision and rationales to wiki/adr
  • I have updated the changes in the ticket description

Checklist for reviewer

  • The code works and does not throw errors
  • The code is easy to understand and there are no confusing parts
  • The code follows the coding guidelines of this project
  • The code change accomplishes what it is supposed to do
  • I cannot think of any use case in which the code does not behave as intended
  • The added and existing tests reasonably cover the code change
  • I cannot think of any test cases, input or edge cases that should be tested in addition
  • Description of the change is included in the documentation

@sangaran10 sangaran10 requested review from MP-DG and removed request for MP-DG January 16, 2026 20:14
@sangaran10 sangaran10 requested a review from MP-DG January 16, 2026 20:19
Copy link
Contributor

@MP-DG MP-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to manually test these changes locally. "it works on my machine"

@sangaran10 sangaran10 merged commit decce2c into main Jan 19, 2026
3 of 5 checks passed
@sangaran10 sangaran10 deleted the progress-visualization branch January 19, 2026 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants