Tidal deformation #773
Open
Tidal deformation #773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 21 commits
January 21, 2025 16:58
# Conflicts: # star/private/hydro_rotation.f90
matthiasfabry
added
enhancement
warrickball
reviewed
Jan 31, 2025
warrickball
reviewed
Jan 31, 2025
warrickball
reviewed
Jan 31, 2025
warrickball
reviewed
Jan 31, 2025
|
Certainly this needs a test_suite. I would love to test it out as well. |
|
As a first test, |
added 4 commits
March 4, 2025 10:33
…formation # Conflicts: # docs/source/changelog.rst # star/other/other_eval_fp_ft.f90 # star/private/hydro_rotation.f90 # star/test_suite/ppisn/src/run_star_extras.f90
|
the tests on c79cdd6 all pass! I'll leave it up here for anyone to test/review, but from my end this is ready to merge. |
pmocz
reviewed
Apr 4, 2025
# Conflicts: # star_data/public/star_data_def.inc
# Conflicts: # binary/test_suite/double_bh/inlist_pgstar # docs/source/changelog.rst
Debraheem
approved these changes
Sep 8, 2025
|
ppisn succeeds locally when turning off rotation flags. Testing on testhub now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on #637, this (rather large) overhaul of
hydro_rotation.f90includes support for computing the stellar structure corrections of tidally distorted stars. This is especially useful when modeling contact binaries.The setup is as follows:
I used procedure hooks (akin to
binary_other_torquefor tidal J_dot calculations) to communicate the binary calculated fp, ft, and i_rot values for the stellar layers.Then these values are "blended" with the single-rotating-star corrections according to the synchronicity of the component to the orbit. I implemented a user hook
binary_other_tidal_deformation_switch_functionif one does not agree with this treatment.The user can still use the
other_fp_ftandother_i_rothooks to bypass all default calculations (and blending).