corrected the error with CPO initial_volume#25
Open
srivatsvyas wants to merge 1 commit intoMFraters:add_drexppfrom
Open
corrected the error with CPO initial_volume#25srivatsvyas wants to merge 1 commit intoMFraters:add_drexppfrom
srivatsvyas wants to merge 1 commit intoMFraters:add_drexppfrom
Conversation
srivatsvyas
commented
Apr 12, 2023
- Made the change discussed to line 194 regarding initial volume fraction. This is reflected in the CPO file output.
- Added an if else for pole deflection in line 99. Created a variable dt to store time of simulation in line 76. If dt = 0, then create a normal rotation matrix. If dt != 0, constrained the pole deflection to 0.1PIthree rather than 2PIthree. Did not test this as had problems with the output and piezometer addtion.
- Added both the piezometer and paleowattmeter in line-718.(just substituted the values in the equation for the paleowattmeter directly so will look messy, sorry :(! ). After making the change to the initial volume fraction, this part does not cause a floating point exception anymore but would be better to check from your side (I tried the paleopiezometer, dont feel comfortable deriving all the terms for the paleowattmeter yet, its there but am still a bit unsure for the equation works so didnt test it now).
- TO-DOs left: the threshold condition for discriminating dislocation creep and diffusion creep.
MFraters
reviewed
Apr 12, 2023
Owner
MFraters
left a comment
There was a problem hiding this comment.
Thanks!
- So is the issue with the initial grain sizes being zero fixed?
- hmm, interesting approach. Did you check whether limits the rotation to 10 degrees? If it does, we can leave it for now, but it probably should become an input parameter for the function later.
- I actually think it is good to split up the equation into multiple parts and then combine them. please add a comment explaining the equation you are solving. Also, I doubt you need a long double for this. a normal double should be fine.
- I can take a look at that.
MFraters
reviewed
Apr 12, 2023
| CrystalPreferredOrientation<dim>::compute_random_rotation_matrix(Tensor<2,3> &rotation_matrix) const | ||
| { | ||
|
|
||
| const double dt = this -> get_time(); |
Owner
There was a problem hiding this comment.
dt is usally used for a time difference, you can just call the variable time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.