fix variable referenced before assignment when using no_filtering_by_…#239
Open
tomhend wants to merge 2 commits intoMIC-DKFZ:masterfrom
Open
fix variable referenced before assignment when using no_filtering_by_…#239tomhend wants to merge 2 commits intoMIC-DKFZ:masterfrom
tomhend wants to merge 2 commits intoMIC-DKFZ:masterfrom
Conversation
added 2 commits
June 2, 2023 16:13
…endpoints, and unecessary indentation
Collaborator
|
Thanks for this contribution. The commit seems to contain more changes, than necessary to solve the "reference before assignment" error. E.g. the -seed and -cutoff parameter for tckgen is removed. Is this intended? |
Author
|
Hello, thanks for the comment. It's not the case that these are removed. The git compare looks to be misalligned because of the repeated code segments and the huge indentation I removed. You can see it matches lines from the iFOD tracking with lines from the FACT tracking now. If you look at the file you will see it all in place. However I haven't rigorously tested this code, it was more a suggestion I guess. If you want to be more sure you can just fix the reference before assignment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…endpoints, and unecessary if statement
When running
Trackingwith--no_filtering_by_endpointsthe variablesbundle_mask_ok,beginnings_mask_ok,endings_mask_okare referenced before assignment in the first if statement below the### Tracking ###comment.Fixed by moving all the code for
filtering_by_endpoints = Trueinto the original if statement, and removing theif filter_by_endpointsin the original if statement underneath### Tracking ###.Tested
Trackingboth with--no_filtering_by_endpointsand without flag, with flag now runs, without produces similar tracts as before.