351 surface genetic expression is broken with current versions of#374
Merged
zihuaihuai merged 8 commits intomasterfrom Nov 26, 2025
Merged
Conversation
- Cast surface Points to float32 before writing to GIFTI format - GIFTI standard only supports uint8, int32, and float32 datatypes - Fixes ValueError: 'Data array has type float64' Fixes #351
Collaborator
Author
|
Also fixed compatibility issues with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed the float64 to float32 dtype issue that was causing GIFTI writing to fail.
Changes
Cast surface Points to float32 before writing to GIFTI format
Added dtype check to avoid unnecessary conversions
Make a copy of the surface to avoid modifying the original data
Why
The surface_genetic_expression function was failing because surface coordinate data was in float64 format, but the GIFTI standard only supports uint8, int32, and float32 datatypes. This caused a ValueError when writing surfaces to GIFTI format.
Testing
The fix ensures that surface data is properly converted to GIFTI-compatible format before writing. Test case included with the fix
close #351