Fix third party dependency installations#201
Merged
jingnanshi merged 1 commit intoMIT-SPARK:masterfrom May 12, 2025
Merged
Conversation
revert to original pmc repo update github workflows switch back to downloaded gtest drop gtest deps and add python workflow add import test fix missing quote static python build fix python installation
Member
|
@nathanhhughes looks great! |
|
As you removed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jingnanshi This bundles a few loosely related changes:
FetchContentinstead of the old manual method for downloading source dependenciesThe changes (to the python bindings) mean that the python documentation is a little out of date and the conda recipes are broken, happy to go fix it at some point if you care about that
@GoldenZephyr this fixes the issue you were seeing if you want to point to this instead of the temporary fix you had