Remove Matomo and adjust libchat injections into remote app boostrapping#27
Remove Matomo and adjust libchat injections into remote app boostrapping#27adamshire123 wants to merge 4 commits intomit-mainfrom
Conversation
|
@JPrevost @jazairi @matt-bernhardt Tagging you three for review on this one. It's a little past my JS / performance knowledge to give effective code review. |
JPrevost
left a comment
There was a problem hiding this comment.
This feels important to discuss removing our centralized web tracking tool.
I appreciate the details on what the problem was and what was tried to resolve it. However, this feels like a discussion that includes DEP Leads so we can understand the ramifications of this change should occur before we proceed with this change.
As the LibChat code is not related to the concern about Matomo being removed without discussion, I'd suggest moving that into a separate pull request so it can proceed.
|
@JPrevost If we keep the matomo tracking code in place, then NDE doesn't work. So I'm not sure waiting to remove it until we have the discussion you propose is practical. |
|
@adamshire123 Do what you want, but removing centralized analytics tooling from NDE was a concern I brought to my boss who confirmed it felt like something to be understood and not just done. |
|
Because NDE is not a live production system yet, I recommend that it is safe to remove Matomo while we do further internal development on NDE. However, I agree with Jeremy that this is a significant change and we need to have a conversation with the DEP leads on this before NDE goes live. @JPrevost do you want to coordinate that conversation or do you want me to? |
|
@amecynth I'd prefer you/the NDE project team coordinate the discussion about this. In the short term, if someone creates a ticket in NDE to have that conversation and add Matomo back (while resolving the problems that currently exist when it is in place) if the discussion warrants, I will remove my block on this code landing. |
|
Thought about it some more... I'm fine with waiting for a meeting before we merge these changes. In the meantime I will upload a customization package with these changes to NDE so we can continue working with it. |
Why these changes are being introduced
Matomo tracking code was causing Firefox to freeze and display a warning about the page slowing Firefox down, so we are removing it completely until we are able to find a solution which allows for its use.
what we would have used Matomo for.
We also want to avoid conflicts with libchat widget script injection and the remote app bootstrapping
How this addresses that need
Side effects of this change
None
How can reviewer(s) test
new code is live here https://mit-psb.primo.exlibrisgroup.com/nde/fulldisplay?query=compendex&tab=all&search_scope=all&searchInFulltext=false&vid=01MIT_INST:NDE&lang=en&docid=alma990008888900106761&adaptor=Local%20Search%20Engine&context=L&isFrbr=false&isHighlightedRecord=false&state=
Relevant ticket(s)
https://mitlibraries.atlassian.net/browse/NDE-3
https://mitlibraries.atlassian.net/browse/NDE-4