Remove ProQuest consent field from receipt email#1407
Merged
Conversation
Why these changes are being introduced: We removed the ProQuest consent field from the thesis submission form, but forgot to remove the field from the mailer. Thus, when a grad student submits their thesis, they see this nonexistent field in their confirmation email. Relevant ticket(s): N/A How this addresses that need: This removes the field from the mailer. Side effects of this change: None.
matt-bernhardt
approved these changes
Dec 20, 2024
Member
matt-bernhardt
left a comment
There was a problem hiding this comment.
I see the tests passing, and I see the updated test is the same format used to confirm that undergraduates aren't seeing the (now-removed) message - so this seems fine for me.
I have not confirmed the mailer itself locally, but the change to the template seems straightforward enough to be reviewable without it. The sentence we want to be removed is just gone.
![]()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why these changes are being introduced:
We removed the ProQuest consent field from the thesis submission form, but forgot to remove the field from the mailer. Thus, when a grad student submits their thesis, they see this nonexistent field in their confirmation email.
Relevant ticket(s):
N/A
How this addresses that need:
This removes the field from the mailer.
Side effects of this change:
None.
Developer
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Code Reviewer
(not just this pull request message)
Requires database migrations?
NO
Includes new or updated dependencies?
NO