Skip to content

USE 346 - --skip-embeddings flag for reindex-source#378

Merged
ghukill merged 1 commit intomainfrom
USE-346-embeddings-optional-with-reindex
Jan 30, 2026
Merged

USE 346 - --skip-embeddings flag for reindex-source#378
ghukill merged 1 commit intomainfrom
USE-346-embeddings-optional-with-reindex

Conversation

@ghukill
Copy link
Contributor

@ghukill ghukill commented Jan 30, 2026

Purpose and background context

Why these changes are being introduced:

There might be times we want to re-index a source to Opensearch without indexing embeddings as a secondary pass.

How this addresses that need:

Add --skip-embeddings flag to reindex-source CLI command.

How can a reviewer manually see the effects of these changes?

1- Set Dev1 credentials

2- Re-index libguides to Dev1, without embeddings:

TIMDEX_OPENSEARCH_ENDPOINT=search-timdex-dev-fgby3dckzlfmni2len2wbdf444.us-east-1.es.amazonaws.com \
pipenv run tim reindex-source \
--skip-embeddings \
-s libguides \
s3://timdex-extract-dev-222053980223/dataset

Note log line:

2026-01-30 11:42:22,123 INFO tim.cli.reindex_source(): Skipping embeddings update.

Includes new or updated dependencies?

NO

Changes expectations for external applications?

NO

What are the relevant tickets?

Code review

  • Code review best practices are documented here and you are encouraged to have a constructive dialogue with your reviewers about their preferences and expectations.

Why these changes are being introduced:

There might be times we want to re-index a source to Opensearch without indexing
embeddings as a secondary pass.

How this addresses that need:

Add --skip-embeddings flag to reindex-source CLI command.

Side effects of this change:
* None

Relevant ticket(s):
* None
@ghukill ghukill marked this pull request as ready for review January 30, 2026 16:43
@ghukill ghukill requested a review from a team as a code owner January 30, 2026 16:43
Copy link
Contributor

@ehanson8 ehanson8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and works as expected!

@ghukill ghukill merged commit bd242c1 into main Jan 30, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants