Skip to content

Update 'format' and 'contributor.kind' values for MITLibWebsite #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonavellecuerdo merged 1 commit into from
Oct 22, 2025
Merged

Update 'format' and 'contributor.kind' values for MITLibWebsite #262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions tests/sources/json/test_mitlibwebsite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,12 @@ def test_mitlibwebsite_transform_returns_timdex_record(mitlibwebsite_records):
value="MIT Libraries",
affiliation=None,
identifier=None,
kind="Creator",
kind="creator",
mit_affiliated=True,
)
],
dates=[timdex.Date(value="2000-01-01T00:00:00", kind="Accessed")],
format="electronic resource",
links=[
timdex.Link(
url="https://libraries.mit.edu/search/",
Expand Down Expand Up @@ -90,7 +91,7 @@ def test_mitlibwebsite_get_content_type_success():
def test_mitlibwebsite_get_contributors_success():
source_record = create_mitlibwebsite_source_record_stub()
assert MITLibWebsite.get_contributors(source_record) == [
timdex.Contributor(value="MIT Libraries", kind="Creator", mit_affiliated=True)
timdex.Contributor(value="MIT Libraries", kind="creator", mit_affiliated=True)
]


Expand All @@ -102,6 +103,12 @@ def test_mitlibwebsite_get_dates_success():
]


def test_mitlibwebsite_get_format_success():
source_record = create_mitlibwebsite_source_record_stub()
mitlibwebsite = MITLibWebsite("mitlibwebsite", iter([source_record]))
assert mitlibwebsite.get_format(source_record) == "electronic resource"


def test_mitlibwebsite_get_links_success():
source_record = create_mitlibwebsite_source_record_stub()
assert MITLibWebsite.get_links(source_record) == [
Expand Down
5 changes: 4 additions & 1 deletion transmogrifier/sources/json/mitlibwebsite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,12 +72,15 @@ def get_content_type(cls, _source_record: dict) -> list[str]:
@classmethod
def get_contributors(cls, _source_record: dict) -> list[timdex.Contributor]:
return [
timdex.Contributor(value="MIT Libraries", kind="Creator", mit_affiliated=True)
timdex.Contributor(value="MIT Libraries", kind="creator", mit_affiliated=True)
]

def get_dates(self, _source_record: dict) -> list[timdex.Date]:
return [timdex.Date(value=self.run_data["run_timestamp"], kind="Accessed")]

def get_format(self, _source_record: dict) -> str:
return "electronic resource"

@classmethod
def get_links(cls, source_record: dict) -> list[timdex.Link]:
return [timdex.Link(url=source_record["url"], kind="Website")]
Expand Down