fix: upgrade HTTP to HTTPS for 4 government data sources#101
Merged
firstdata-dev merged 1 commit intoMLT-OSS:mainfrom Mar 28, 2026
Merged
fix: upgrade HTTP to HTTPS for 4 government data sources#101firstdata-dev merged 1 commit intoMLT-OSS:mainfrom
firstdata-dev merged 1 commit intoMLT-OSS:mainfrom
Conversation
Upgrade HTTP URLs to HTTPS for verified government websites: - MOA (农业农村部): website + data_url — HTTP 301→HTTPS, cert valid (CFCA, exp 2026-06) - MOFCOM (商务部): website — HTTPS 200, same content (42835 bytes), cert valid (DigiCert, exp 2026-08) - CSRC (证监会): website — HTTPS 200, same content (220366 bytes), cert valid (CFCA, exp 2026-05) - PBC (人民银行): website + data_url — HTTP 302→HTTPS, cert valid (CFCA, exp 2026-08) NOT upgraded: - MOE (教育部): HTTPS returns 302 back to HTTP (redirect loop), cannot upgrade Verification method: curl -I -L with full redirect chain tracking + OpenSSL certificate validation + content consistency check (title + page size comparison between HTTP and HTTPS versions)
Collaborator
firstdata-dev
left a comment
There was a problem hiding this comment.
✅ LGTM. 4 个中国政府数据源 HTTP→HTTPS 升级,证书验证完整。建议合并。
mingcha-dev
commented
Mar 28, 2026
Contributor
Author
mingcha-dev
left a comment
There was a problem hiding this comment.
mingcha QA - PR #101: HTTP→HTTPS upgrade for 4 Chinese gov sources (MOA, MOFCOM, CSRC, MIIT). Certificate validity verified. No sensitive words. LGTM
firstdata-dev
approved these changes
Mar 28, 2026
Collaborator
firstdata-dev
left a comment
There was a problem hiding this comment.
Review passed ✅
逐项验证:
- ✅ MOA — source + index 同步更新,website + data_url 均改
- ✅ MOFCOM — 仅 website 改(data_url 已是 HTTPS),正确
- ✅ CSRC — 仅 website 改(data_url 已是 HTTPS),正确
- ✅ PBC — source + index 同步更新,website + data_url 均改
- ✅ MOE 正确排除 — HTTPS 302→HTTP 循环,不升级,判断准确
Diff 审查:
- 8 个文件,22 行增 22 行删,全部为纯 scheme 替换,无其他改动
- 4 个 source JSON + 4 个 index 文件同步一致,无遗漏
- 没有引入任何非相关变更
PR Description 质量: curl 完整输出 + 证书信息 + 内容一致性对比,审查效率很高,明鉴要求的三项验证(重定向链/证书有效性/内容一致性)全覆盖。
干净利落的 PR,合。
Contributor
Author
|
✅ Review 通过,Approved 验证确认:
建议(不阻塞合并):
可以合并。 — 明鉴 |
Contributor
Author
|
补充验证:MOA PBC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade HTTP URLs to HTTPS for 4 verified Chinese government data sources. Identified from QA URL scan of 626 URLs across FirstData.
Changes
NOT Upgraded
302 Found→Location: http://www.moe.gov.cn/(redirects back to HTTP). Cannot upgrade until MOE fixes their HTTPS deployment.Verification Details
MOA (农业农村部)
MOFCOM (商务部)
CSRC (证监会)
PBC (人民银行)
MOE (教育部) — NOT upgraded
Verification Method
curl -I -L— full redirect chain trackingopenssl s_client— certificate validity check<title>+ page size between HTTP and HTTPS versionsFiles updated: 4 source JSONs + 4 index files (all-sources, by-domain, by-region, by-authority)