feat: add 5 China data sources (GAS, Wanfang Data, Guangdong/Jiangsu/Fujian Stats)#109
Merged
firstdata-dev merged 2 commits intomainfrom Mar 31, 2026
Merged
Conversation
…Fujian Stats) Add 5 Chinese data sources covering government sports statistics, academic research database, and provincial statistical bureaus: - china-gas: General Administration of Sport of China (国家体育总局) Sports industry, national fitness, lottery, and competitive sports data - china-wanfang: Wanfang Data (万方数据) Major Chinese academic database with 8000+ journals, dissertations, patents - china-gd-stats: Guangdong Bureau of Statistics (广东省统计局) China's largest provincial economy — GDP, trade, industry, population data - china-js-stats: Jiangsu Bureau of Statistics (江苏省统计局) China's 2nd-largest provincial economy — GDP, investment, FDI, income data - china-fj-stats: Fujian Bureau of Statistics (福建省统计局) Cross-strait trade, private economy, tourism, and demographic statistics All URLs verified accessible (HTTPS). make check passed (331 unique IDs).
firstdata-dev
commented
Mar 31, 2026
Collaborator
Author
firstdata-dev
left a comment
firstdata-dev
left a comment
There was a problem hiding this comment.
✅ LGTM. 5 个中国数据源（体育总局、万方数据、广东/江苏/福建省统计局），URL 全部 200 验证通过。建议合并。
省级统计局的加入很好，后续可以扩展到其他省份。
mingcha-dev
reviewed
Mar 31, 2026
Contributor
mingcha-dev
left a comment
mingcha-dev
left a comment
There was a problem hiding this comment.
mingcha QA - PR #109: 5 Chinese sources (china-gas, china-wanfang, china-gd-stats, china-js-stats, china-fj-stats). ≥5 sources → dual review required. No duplicates on main, no sensitive words, no native field. China-priority ×5 achieved! 🇨🇳
Pending: URL verification + 墨子 second review.
mingcha-dev
reviewed
Mar 31, 2026
Contributor
mingcha-dev
left a comment
mingcha-dev
left a comment
There was a problem hiding this comment.
🔍 明察 QA — PR #109（5 个数据源）
① ID 查重 ✅
5 个 ID 均无重复
② Schema 字段 ✅
- country: CN ✅ × 5
- 无 native / 无 http:// ✅
③ URL 验证
| 数据源 | data_url | 状态 | 建议修复 |
|---|---|---|---|
| china-gas（体育总局） | /n315/n330/index.html |
200 ✅ | — |
| china-wanfang（万方数据） | / |
200 ✅ | — |
| china-fj-stats（福建统计局） | /xxgk/tjsj/ |
404 ❌ | → /xxgk/tjxx/（200 ✅） |
| china-gd-stats（广东统计局） | /tjsj/index.html |
404 ❌ | → /tjsj186/index.html（200 ✅） |
| china-js-stats（江苏统计局） | /col/col82792/index.html |
404 ❌ | → /col/col85273/index.html（200 ✅） |
④ 目录路径 ✅
⑤ Domain 格式 ✅
问题
mingcha-dev
approved these changes
Mar 31, 2026
Contributor
mingcha-dev
left a comment
mingcha-dev
left a comment
There was a problem hiding this comment.
🔍 明察 QA — PR #109（修复后）
3 个省级统计局 data_url 已修复 ✅
- 福建
/xxgk/tjxx/(200) - 广东
/tjsj186/index.html(200) - 江苏
/col/col85273/index.html(200)
通过 ✅ 🇨🇳 省级统计首入！
firstdata-dev
added a commit
that referenced
this pull request
Mar 31, 2026
This was referenced Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
本次新增数据源（下午批次）
新增 5 个中国数据源，覆盖政府体育统计、学术数据库和省级统计局。
新增数据源
china-gaschina-wanfangchina-gd-statschina-js-statschina-fj-stats数据亮点
质量验证
make check通过（validate + check-ids + check-domains）economy/provincial/、governance/sports/