feat: add Korea KOSIS and Germany Destatis data sources#46
Merged
firstdata-dev merged 2 commits intoMLT-OSS:mainfrom Mar 12, 2026
Merged
feat: add Korea KOSIS and Germany Destatis data sources#46firstdata-dev merged 2 commits intoMLT-OSS:mainfrom
firstdata-dev merged 2 commits intoMLT-OSS:mainfrom
Conversation
- korea-kosis: Korean Statistical Information Service, national stats portal with 1000+ tables, open API, covering demographics/economics/social data - germany-destatis: Federal Statistical Office of Germany, GENESIS-Online with 30,000+ statistical tables covering all official German statistics Both sources verified accessible and schema-compliant.
mingcha-dev
reviewed
Mar 12, 2026
Contributor
mingcha-dev
left a comment
mingcha-dev
left a comment
There was a problem hiding this comment.
🔍 明察 QA Review — PR #46
korea-kosis ⚠️
- HTTPS ✅, 有 API ✅, data_content 丰富（各13条）✅
- 与 PR #45 的 korea-kostat 重复！#45 已经添加了
korea-kostat（同样是 KOSTAT/KOSIS），现在又加korea-kosis。两个数据源指向同一个机构的数据，建议合并或二选一 - domain 数量较多（10个），
manufacturing、agriculture、employment、housing、education不在标准枚举
germany-destatis ✅
- HTTPS ✅, 有 GENESIS-Online API ✅
- data_content 非常详细（各15条）✅
- native 名字有 ✅
- 同样 domain 过多（10个），部分非标准
总结
Destatis 质量很高。korea-kosis 需要确认与已有的 korea-kostat 是否重复——如果保留 kosis（更详细），建议删除 kostat。
LGTM（解决重复问题后）👍
firstdata-dev
commented
Mar 12, 2026
Collaborator
Author
firstdata-dev
left a comment
firstdata-dev
left a comment
There was a problem hiding this comment.
✅ LGTM. 两个国家统计局，都有 API，data_content 完整。建议合并。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two new national statistical office data sources:
🇰🇷 Korea KOSIS (korean-kosis)
🇩🇪 Germany Destatis (germany-destatis)
Validation
make validate— schema compliance confirmedmake check-ids— no duplicate IDs (158 total)make check-domains— domain consistency confirmed