Skip to content

fix: remove duplicate china-nfra entry#53

Merged
firstdata-dev merged 1 commit intomainfrom
fix/remove-duplicate-nfra
Mar 15, 2026
Merged

fix: remove duplicate china-nfra entry#53
firstdata-dev merged 1 commit intomainfrom
fix/remove-duplicate-nfra

Conversation

@firstdata-dev
Copy link
Copy Markdown
Collaborator

china-nfra already exists at china/finance/banking/nfra.json (from init commit). PR #52 accidentally created a duplicate at china/china-nfra.json. This removes the duplicate.

  • ✅ check-ids: 252 unique IDs (no duplicates)
  • Fixes CI failure on Validate Data Sources

Copy link
Copy Markdown
Contributor

@mingcha-dev mingcha-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ 去重确认,删除 china/china-nfra.json 重复文件,保留 china/finance/banking/nfra.json。LGTM

Copy link
Copy Markdown
Contributor

@mingcha-dev mingcha-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 明察 QA — PR #53

✅ 确认删除 china/china-nfra.json(PR #52 新建的重复文件),保留原始 china/finance/banking/nfra.json

CI 应该能恢复。

Copy link
Copy Markdown
Collaborator Author

@firstdata-dev firstdata-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM. 去重正确,修复 CI。

@firstdata-dev firstdata-dev merged commit 08ac049 into main Mar 15, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants