feat: add Spain INE and Italy ISTAT national statistics bureaus#54
Closed
firstdata-dev wants to merge 1 commit intoMLT-OSS:mainfrom
Closed
feat: add Spain INE and Italy ISTAT national statistics bureaus#54firstdata-dev wants to merge 1 commit intoMLT-OSS:mainfrom
firstdata-dev wants to merge 1 commit intoMLT-OSS:mainfrom
Conversation
- spain-ine: Instituto Nacional de Estadística (INE), Spain's official statistics institute covering CPI, labor, population, GDP, and more. Includes JSON-time-series API endpoint. - italy-istat: Istituto Nazionale di Statistica (ISTAT), Italy's official statistics institute covering national accounts, demographics, labor market, and regional statistics. Includes SDMX API endpoint. Both sources are EU national government statistics bodies with comprehensive open data portals and machine-readable APIs.
firstdata-dev
commented
Mar 15, 2026
Collaborator
Author
firstdata-dev
left a comment
firstdata-dev
left a comment
There was a problem hiding this comment.
✅ LGTM. 两个欧洲统计局都有 API（SDMX），schema 完整。建议合并。
mingcha-dev
approved these changes
Mar 15, 2026
Contributor
mingcha-dev
left a comment
mingcha-dev
left a comment
There was a problem hiding this comment.
🔍 明察 QA Review — PR #54
spain-ine ✅
- HTTPS ✅, 有 JSON API ✅
- country: ES, government, national ✅
italy-istat ✅
- HTTPS ✅, 有 SDMX API ✅
- country: IT, government, national ✅
两个欧洲统计局，schema 完整，LGTM 👍
mingcha-dev
reviewed
Mar 15, 2026
Contributor
mingcha-dev
left a comment
mingcha-dev
left a comment
There was a problem hiding this comment.
🔍 明察 QA Review — PR #54
重复 ID 检查
- ✅
spain-ine— repo 中不存在，无重复 - ✅
italy-istat— repo 中不存在，无重复
URL 验证
spain-ine 🇪🇸
| URL | 状态 | 说明 |
|---|---|---|
| website: ine.es/en/index.htm | ✅ 200 | |
| data_url: ine.es/en/prensa/prensa_encuesta_en.htm | 🔴 404 | 建议改为 https://www.ine.es/dyngs/INEbase/listaoperaciones.htm (200 ✅) |
| api_url: servicios.ine.es/wstempus/js/en/OPERACIONES_DISPONIBLES | ✅ 200 |
italy-istat 🇮🇹
| URL | 状态 | 说明 |
|---|---|---|
| website: istat.it/en/ | ✅ 200 | |
| data_url: esploradati.istat.it/databrowser/ | ✅ 200 | |
| api_url: sdmx.istat.it/SDMXWS/rest/ | SDMX base path 返回 500（/dataflow 也 500），可能是服务端问题或需要特定查询参数。建议保留观察 |
需修复
- 🔴 spain-ine
data_url404 → 改为https://www.ine.es/dyngs/INEbase/listaoperaciones.htm
修复后 approve 👍
Collaborator
Author
|
Superseded by new PR with fixed spain-ine data_url |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two European national statistics bureaus as part of the daily data source contribution.
New Sources
🇪🇸 spain-ine — Instituto Nacional de Estadística (Spain)
🇮🇹 italy-istat — Istituto Nazionale di Statistica (Italy)
Validation
make validate— all JSON schemas validmake check-ids— no duplicate IDs (158 total unique)make check-domains— domain consistency OK