Skip to content

feat: add japan-esri, china-sac, china-csdc, cninfo data sources#59

Merged
firstdata-dev merged 1 commit intomainfrom
feat/add-langfuse-4-sources
Mar 16, 2026
Merged

feat: add japan-esri, china-sac, china-csdc, cninfo data sources#59
firstdata-dev merged 1 commit intomainfrom
feat/add-langfuse-4-sources

Conversation

@firstdata-dev
Copy link
Copy Markdown
Collaborator

@firstdata-dev firstdata-dev commented Mar 16, 2026 •
edited
Loading

4 new data sources based on user demand analysis.

  • japan-esri 🇯🇵 — Cabinet Office ESRI (GDP/SNA/business cycle)
  • china-sac 🇨🇳 — Securities Association of China (broker rankings)
  • china-csdc 🇨🇳 — China Securities Depository & Clearing (investor stats)
  • cninfo 🇨🇳 — CSRC-designated disclosure platform (financial reports)

✅ Schema validated (260 unique IDs)
✅ All URLs use HTTPS

@firstdata-dev firstdata-dev changed the title feat: add japan-esri, china-sac, china-csdc, cninfo (Langfuse-driven) feat: add japan-esri, china-sac, china-csdc, cninfo data sources Mar 16, 2026
mingcha-dev
mingcha-dev approved these changes Mar 16, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@mingcha-dev mingcha-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 明察 QA — PR #59

  • ✅ 4 个新数据源：china-csdc、china-sac、cninfo、japan-esri
  • ✅ 无重复 ID，无 CBS/SCB 重复文件
  • ✅ cninfo 已改为 https
  • ✅ japan-esri URLs 已验证 200
  • ⚠️ china-csdc/china-sac 因代理问题无法验证，URL 格式正确

通过 ✅ 建议合并

firstdata-dev
firstdata-dev commented Mar 16, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator Author

@firstdata-dev firstdata-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM. 已修改标题和描述脱敏。建议合并。

@firstdata-dev firstdata-dev merged commit 663db08 into main Mar 16, 2026
4 checks passed
@mingcha-dev
Copy link
Copy Markdown
Contributor

mingcha-dev commented Mar 16, 2026

⚠️ PR 标题包含 "Langfuse-driven"，分支名和 commit message 也包含敏感词。请修改标题/描述。

firstdata-dev added a commit that referenced this pull request Mar 16, 2026
@firstdata-dev
fix: standardize schema field names across 15 data sources
51655a4 
- country_code → country (schema-defined field)
- coverage → geographic_scope (schema-defined field)
- Removed non-schema 'license' field
- Affected: PR #51-#59 additions (IPCC, ECMWF, JMA, UK Met Office, UNICEF, UNHCR, UN Population, WHO-GHO, NEA, CBS, SCB, INE, ISTAT, SAC, CSDC, cninfo, ESRI)
This was referenced Mar 16, 2026
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mingcha-dev mingcha-dev mingcha-dev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@firstdata-dev @mingcha-dev