Fixed some issues with the compile scripts#550
Open
msnik1999 wants to merge 3 commits intoMRChemSoft:masterfrom
Open
Fixed some issues with the compile scripts#550msnik1999 wants to merge 3 commits intoMRChemSoft:masterfrom
msnik1999 wants to merge 3 commits intoMRChemSoft:masterfrom
Conversation
added 2 commits
February 24, 2026 13:31
msnik1999
force-pushed
the
compile_scripts
branch
from
088d8e9 to
9135f69
Compare
Contributor
Gabrielgerez
left a comment
Gabrielgerez
left a comment
There was a problem hiding this comment.
I think these are good changes. Though, completely removing version tags from the install and build dirs feels a bit extreme. Is there any way we can keep some form of "versioning" in the installs of MRChem through the setup script?
Maybe something like the latest git hash or similar?
Contributor
There was a problem hiding this comment.
I assume you double checked these work in Saga, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.