Skip to content

Improve visuals and sound#178

Draft
marcinn wants to merge 1 commit intomainfrom
dev/gnd_addons
Draft

Improve visuals and sound#178
marcinn wants to merge 1 commit intomainfrom
dev/gnd_addons

Conversation

@marcinn
Copy link
Copy Markdown
Member

@marcinn marcinn commented Apr 21, 2026

marcinn
marcinn commented Apr 21, 2026
View reviewed changes
Comment thread demo/addons/gnd_sfx/sfx_bank.gd
@export var events: Array[SfxEvent] = []:
set(x):
events = x
_rebuild_events_cache()
Copy link
Copy Markdown
Member Author

@marcinn marcinn Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it causes problems

marcinn
marcinn commented Apr 21, 2026
View reviewed changes
Comment thread src/core/GenericTrainPart.cpp
Dictionary GenericTrainPart::_get_train_part_state() {
return internal_state;
};
void GenericTrainPart::update_state(const Dictionary &state) {
Copy link
Copy Markdown
Member Author

@marcinn marcinn Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is workaround for state issues. The state after sending a command is eventually-consistent and may not be up to date. This inconsistency causes issues with locking cabin switches.

@marcinn
Improve visuals and sound
19f2f97 
* Adds initial gnd_skydome addon (solves #73)
* Adds initial gnd_sfx addon (solves #90)
* Adds initial gnd_weather addon for weather system (related to #74 and #73)
* Adds more sounds to SM42 demo
This was linked to issues Apr 22, 2026
Implement audio stream player or audio interactive stream for layered sounds #90
Open
Implement sky shader #73
Open
Implement custom materials #74
Open
@marcinn
Copy link
Copy Markdown
Member Author

marcinn commented Apr 26, 2026

This pr is too big. Split sounds to a separate PR first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement audio stream player or audio interactive stream for layered sounds Implement custom materials Implement sky shader

1 participant

@marcinn