math/big: fix the bug of testShiftFunc in arith_test.go#14
Open
SparrowLii wants to merge 6 commits intoMabinGo:masterfrom
Open
math/big: fix the bug of testShiftFunc in arith_test.go#14SparrowLii wants to merge 6 commits intoMabinGo:masterfrom
SparrowLii wants to merge 6 commits intoMabinGo:masterfrom
Conversation
Fixes golang#39406 When use checkForResumption() function it could be side-effect sometime. 1. hs.sessionState will be changed and retained although the function return false. 2. hs.suite will be changed and retained when the statements below return false. So we should use a local variable, cilentSessionState, to replace hs.sessionState in the function. And move the set-suite statements down to avoid being changed too early.
The function will breakdown setting '-count' argument plural during testing. The change uses copy instead of assigning statement to avoid this.
|
可以具体描述一下bug吗，目前看起来，修改前测试用例是通过的 |
surechen
reviewed
Aug 24, 2020
| copy(b, a.d) | ||
| z := a.d[a.zp : a.zp+a.l] | ||
| x := a.d[a.xp : a.xp+a.l] | ||
| z:=make([]Word,a.l) |
Author
在终端输入 go test math/big -count=2会报错。经测试只要将count参数设为1以上就会报错，原因是原代码在测试函数执行过程中改变了所输入原始数据的值，但期望输出未变，所以会造成多次测试中结果错误的bug |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
math/big: fix the bug of testShiftFunc in arith_test.go
The function will breakdown setting '-count' argument plural during testing.
The change uses copy instead of assigning statement to avoid this.
This PR will be imported into Gerrit with the title and first
comment (this text) used to generate the subject and body of
the Gerrit change.
Please ensure you adhere to every item in this list.
More info can be found at https://github.com/golang/go/wiki/CommitMessage
net/http: frob the quux before blarfing"This change modifies Go to ___________"
really needed (ASCII art, table, or long link)
Fixes #1234orUpdates #1234(the latter if this is not a complete fix) to this comment
golang/goyou can use theowner/repo#issue_numbersyntax:Fixes golang/tools#1234Our Gerrit server & GitHub bots enforce CLA compliance instead.