Skip to content

Fix missing ProfileVersionQuery method from mock profile stores #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
babypatrick100 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix missing ProfileVersionQuery method from mock profile stores #46

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b9927b
Fix missing `ProfileVersionQuery` method for mock profile stores
babypatrick100 Aug 31, 2024
c75d2cd
Update ProfileService.lua
babypatrick100 Aug 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions ProfileService.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2100,16 +2100,12 @@ function ProfileStore:ProfileVersionQuery(profile_key, sort_direction, min_date,
error("[ProfileService]: Invalid profile_key")
end

if ProfileService.ServiceLocked == true then
if ProfileService.ServiceLocked == true or _use_mock == UseMockTag or UseMockDataStore == true then
return setmetatable({}, ProfileVersionQuery) -- Silently fail :Next() requests
end

WaitForPendingProfileStore(self)

if _use_mock == UseMockTag or UseMockDataStore == true then
error("[ProfileService]: :ProfileVersionQuery() is not supported in mock mode")
end

-- Type check:
if sort_direction ~= nil and (typeof(sort_direction) ~= "EnumItem"
or sort_direction.EnumType ~= Enum.SortDirection) then
Expand Down Expand Up @@ -2231,8 +2227,8 @@ function ProfileService.GetProfileStore(profile_store_index, profile_template) -
ViewProfileAsync = function(_, profile_key, version)
return profile_store:ViewProfileAsync(profile_key, version, UseMockTag)
end,
FindProfileVersionAsync = function(_, profile_key, sort_direction, min_date, max_date)
return profile_store:FindProfileVersionAsync(profile_key, sort_direction, min_date, max_date, UseMockTag)
ProfileVersionQuery = function(_, profile_key, sort_direction, min_date, max_date)
return profile_store:ProfileVersionQuery(profile_key, sort_direction, min_date, max_date, UseMockTag)
end,
WipeProfileAsync = function(_, profile_key)
return profile_store:WipeProfileAsync(profile_key, UseMockTag)
Expand Down Expand Up @@ -2411,4 +2407,4 @@ task.spawn(function()
)
end)

return ProfileService
return ProfileService