Fix tool call ID in message object#361
Open
gurvinder-dhillon wants to merge 1 commit intoMadcowD:mainfrom
Open
Fix tool call ID in message object#361gurvinder-dhillon wants to merge 1 commit intoMadcowD:mainfrom
gurvinder-dhillon wants to merge 1 commit intoMadcowD:mainfrom
Conversation
Fixes MadcowD#325 Add `tool_call_id` attribute to `Message` class and update methods to handle it. * Add `tool_call_id` attribute to `Message` class in `src/ell/types/message.py`. * Update `__init__` method in `Message` class to accept `tool_call_id` parameter. * Update `model_validate` method in `Message` class to handle `tool_call_id`. * Update `translate_to_provider` method in `src/ell/providers/openai.py` to add `tool_call_id` to `Message` object. * Update `translate_from_provider` method in `src/ell/providers/openai.py` to process `tool_call_id` in `Message` object. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/MadcowD/ell/issues/325?shareId=XXXX-XXXX-XXXX-XXXX).
Owner
|
this isn't my preferred fix. i don't want toocall ids to live on messages but on the content objects internal to them. Can you take a look a bit deeper here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #325
Add
tool_call_idattribute toMessageclass and update methods to handle it.tool_call_idattribute toMessageclass insrc/ell/types/message.py.__init__method inMessageclass to accepttool_call_idparameter.model_validatemethod inMessageclass to handletool_call_id.translate_to_providermethod insrc/ell/providers/openai.pyto addtool_call_idtoMessageobject.translate_from_providermethod insrc/ell/providers/openai.pyto processtool_call_idinMessageobject.For more details, open the Copilot Workspace session.