Open
Conversation
| use MadeHQ\Markdown\Forms\MarkdownEditorField; | ||
|
|
||
| define('MARKDOWN_MODULE_BASE', basename(dirname(__FILE__))); | ||
| define('MARKDOWN_MODULE_BASE', 'mademedia/silverstripe-markdown'); |
There was a problem hiding this comment.
Just a minor question on this, what's the reasoning behind altering this to be hard coded, over just leaving it to be dynamically set in PHP?
Author
There was a problem hiding this comment.
I think basename(dirname(__FILE__)) will only return the current folder (eg: silverstripe-markdown), in SS4 you need to provide the composer package name when trying to require JS/CSS.
As you guys are using MARKDOWN_MODULE_BASE in all your Requirements calls, it was a little easier to just change this.
I am not sure if there is a way of getting the package name from composer direct...
AndrewLowther
left a comment
AndrewLowther
left a comment
There was a problem hiding this comment.
Tested on a local install of SS4, works like a charm 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just adding some more SS4 support, I have: