setMask on NavDataManager is not called correctly from adding/removing listeners#23
Open
jfbenckhuijsen wants to merge 2 commits intoMahatmaX:masterfrom
Open
setMask on NavDataManager is not called correctly from adding/removing listeners#23jfbenckhuijsen wants to merge 2 commits intoMahatmaX:masterfrom
jfbenckhuijsen wants to merge 2 commits intoMahatmaX:masterfrom
Conversation
the mask was only set in case *listeners.size() > 2. Otherwise, the mask was always reset. Now, the reset is only performed if the number of listeners drops to 0, and set if there is one listener present (assuming it's the first).
jfbenckhuijsen
changed the title
Author
|
Branched from our maveninzed branch. The fix is in the single commit in this branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.