Next batch of fixes #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike Destroy(foo), foo.DestroyJoint() will crash if foo is null.
Update KAS base from Majiir and Angavrilov work
Spelling/grammar fixes for part descriptions
Fix NRE when grabbing a stateful part from a container.
On KSP x64, a coroutine is needed for waiting decouple action to finish. Grab function has been redone to reflect that. (+ others minor fix)
Changed the method for attaching the part to the kerbal. Setting iskinematic to true and/or physicalSignificance to none mess up things at some velocity/orbit (ex orbiting moon). Now the part is updating is position every frame when grabbed.
Fixed grapple not being correctly detached when a joint is broken. Added new methods to check if a static or fixed joint is broken
On KSP X64, ejection force are not applied on winches. Delayed the addforce method to one frame after to fix the problem.
It's now possible to retract directly after an ejection without using extend first
Winches head can't lock sometimes, raising lockMinDist to avoid it
Implemented IPartCostModifier.
…d a patch to fixup any 3rd party storable science parts for recovery from containers.
Science Recovery & Module Manager Conversion
A private method that is called from outside the class not via a delegate is in itself a violation of the encapsulation concepts of the language.
…des. Also, instead of custom code, try using the function KSP itself uses to compute costs when recovering a vessel.
This interface allows infinite retransmission by clicking on the antenna and choosing Transmit Data, and it is not even used for recovery.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the release near I think it's time to merge this. I've been playing with it, so it should be fine. :)