Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Is this design on purpose or only temporary? I find it a bit odd. Especially because send and receive buttons are different. Seems like somehow send is more important action now. I personally see send and receive as equivalent actions just in opposite direction. Thus if we want all 3 buttons here, I would style those two the same (same style and width) and make buy different. |
jbojcic1
left a comment
jbojcic1
left a comment
There was a problem hiding this comment.
I think this looks much cleaner without trying to reuse receive page, store, etc.
| </div> | ||
|
|
||
| <div className="w-full max-w-sm sm:max-w-none"> | ||
| <AccountSelector |
There was a problem hiding this comment.
should we maybe not even show it if the accounts.length is 1?
There was a problem hiding this comment.
Why? If we did that then we shold remove the account selector from the send and receive inputs too in that case
There was a problem hiding this comment.
yeah I'd do it there as well but we can see about that. not related to this pr
on purpose, but we can iterate on it. I agree that this makes send seem like the primary action, but actually I think Receive and Buy should be the primary actions and then send secondary. This is because if we are targetting gift card users they should be sending from the gift card page |
|
@jbojcic1 I added two more commits |
to me send seems primary here because it's way bigger than the other two and it feels like we are calling for that action |
jbojcic1
left a comment
jbojcic1
left a comment
There was a problem hiding this comment.
apporoving but pls check the last set of comments
| </PageHeader> | ||
| <PageContent className="flex flex-col items-center gap-4"> | ||
| <MoneyWithConvertedAmount money={amount} /> | ||
| {isMobile ? ( |
There was a problem hiding this comment.
I find this hard to read with this very long chaining of:
isMobile ? (bunch of elements) : errorMessage ? (elements) : (elements)
I think it sould be reorganized so you can see at first glance what is rendered on mobile and what on desktop and what on error.
I'd probably just create a component int his file for mobile and for desktop and then render those here
2 participants
Adds the ability to buy bitcoin via Cash App deep link. Builds on input-refactoring.
First commit extends the receive store and second commit adds the cashapp deep link flow.