Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
gudnuf
force-pushed
the
gift-card-add-funds
branch
from
edfbe89 to
981d83c
Compare
jbojcic1
left a comment
jbojcic1
left a comment
There was a problem hiding this comment.
is there a way to tell that some transfer was actually done via transfer ui as opposed to getting an ln invoice from receive flow and paying it via send flow?
| ); | ||
|
|
||
| // TODO: Talk to Josip — this manually transitions DRAFT→PENDING after creation. | ||
| // Ideally the receive quote would be created as PENDING from the start (like CASHU_TOKEN), |
There was a problem hiding this comment.
yeah we definitely should me manually transitioning it
|
we have more and more stuff that we place under features that depends on other features. this means we kind of failed atm with vertically slicing the portions of the app and still ended up with everything depending on everything. it's more like a folder structure only atm and that was not my initial intention nothing to act on this here but I will need to think about this a bit more and see if I can come up with some plan to break things up |
Not sure what you mean. We know the transfer is completed when the receive quote is paid |
gudnuf
force-pushed
the
gift-card-add-funds
branch
from
981d83c to
84ce5b0
Compare
gudnuf
changed the title
| <LinkWithViewTransition | ||
| to={buildLinkWithSearchParams('/receive', { | ||
| accountId: card.id, | ||
| redirectTo: `/gift-cards/${card.id}`, |
There was a problem hiding this comment.
@claude this redirectTo should not have been removed. We still want to reidrect back when the transfer is completed
There was a problem hiding this comment.
Claude finished @gudnuf's task in 54s —— View job
Restored redirectTo on gift card transfer link
- Read the current file and diff to understand the removed code
- Restore the
redirectToparameter - Push the fix
The "Add" button's link was missing the redirectTo search param. Restored it using buildLinkWithSearchParams (same pattern as the "Send" button), so navigating back after transfer completion works correctly.
Commit: 46c27c4
gudnuf
force-pushed
the
add-buy-transfer-types
branch
from
6f10605 to
6423c97
Compare
gudnuf
force-pushed
the
gift-card-add-funds
branch
from
46c27c4 to
32ff958
Compare
2 participants
Adds the ability to top up gift cards by transferring funds between accounts via Lightning. Builds on input-refactoring.