ui nits and redirect to gift card after checking out#924
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
@jbojcic1 I had claude profile your review feedback. I made these changes based on that. 
|
|
|
||
| const buttonVariants = cva( | ||
| 'inline-flex items-center justify-center gap-2 whitespace-nowrap rounded-md font-medium text-sm ring-offset-background transition-colors focus-visible:outline-hidden focus-visible:ring-2 focus-visible:ring-ring focus-visible:ring-offset-2 disabled:pointer-events-none disabled:opacity-50 [&_svg]:pointer-events-none [&_svg]:size-4 [&_svg]:shrink-0', | ||
| 'inline-flex items-center justify-center gap-2 whitespace-nowrap rounded-md border border-transparent font-medium text-sm ring-offset-background transition-colors focus-visible:outline-hidden focus-visible:ring-2 focus-visible:ring-ring focus-visible:ring-offset-2 disabled:pointer-events-none disabled:opacity-50 [&_svg]:pointer-events-none [&_svg]:size-4 [&_svg]:shrink-0', |
There was a problem hiding this comment.
This makes it so that all buttons have a border but defaults to transparent which is needed to make it so that with or without a visual border the height is exactly the same
so this seems like an issues that was already in this component. The outline variant already had a border and I also added a border to the secondary variant which made those variants slightly taller with the added border.
Bob noticed it because the "Receive" and "Buy" buttons are right above the "Send" button
| {isMobile && !errorMessage && ( | ||
| <PageFooter className="pb-14"> | ||
| <Button asChild> | ||
| <Button asChild className="w-[80px]"> |
There was a problem hiding this comment.
this is the same width as our "Ok" buttons
2 participants
some ui nits that claude reverted when I refactored the checkout page.
Also this makes it so that if the user is buying to a gift card account, then the transaction details "Ok" button will redirect them to the gift card page rather than home.